-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: openid4vc and sd-jwt-vc support #1708
feat: openid4vc and sd-jwt-vc support #1708
Conversation
Co-authored-by: Martin Auer (2mau) <martin.auer97@gmail.com> Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work @TimoGlastra and @2mau !!!
There are indeed quite some FIXME's, TODO's and NOTE's in there but I am perfectly fine with fixing them in other PRs as this PR already made my browser lag a whole bunch ;).
I think it would be good if another person went over it as with such a big PR, you tend to miss some details in some places.
packages/core/src/modules/dif-presentation-exchange/DifPresentationExchangeService.ts
Outdated
Show resolved
Hide resolved
packages/core/src/modules/dif-presentation-exchange/DifPresentationExchangeService.ts
Show resolved
Hide resolved
packages/openid4vc/src/openid4vc-verifier/OpenId4VcSiopVerifierService.ts
Show resolved
Hide resolved
packages/openid4vc/src/openid4vc-verifier/OpenId4VcSiopVerifierService.ts
Show resolved
Hide resolved
packages/openid4vc/src/openid4vc-verifier/repository/OpenId4VcVerifierRecord.ts
Show resolved
Hide resolved
…ationExchangeService.ts Co-authored-by: Berend Sliedrecht <61358536+berendsliedrecht@users.noreply.github.com> Signed-off-by: Timo Glastra <timo@animo.id>
Co-authored-by: Berend Sliedrecht <61358536+berendsliedrecht@users.noreply.github.com> Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Supersedes #1667, as there were issues with DCO sign-off
It works e2e with openid4vc issuance, and verification with SD-JWT-VC, BUTT there's still some todos, but If possible I'd like to do it in follow up PRs as this one is already huge.
Some of the todos:
Here's a list of PRs that if released will allow for some cleanup on our side (but we can do that after this PR is merged):